Draft
Add e2e tests verifying pod spec fields are propagated to generated pods#30
Conversation
Agent-Logs-Url: https://github.com/flanksource/batch-runner/sessions/7a9cd0f6-c47b-48ff-acf9-b87bf673cd72 Co-authored-by: moshloop <1489660+moshloop@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
moshloop
April 15, 2026 07:18
View session
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No e2e coverage existed to confirm that pod spec fields set on a
BatchTrigger(tolerations, annotations, nodeSelector, securityContext, initContainers, resource limits, env vars) actually appear on the created pod.New fixture:
fixtures/pod-spec.yamlA
BatchTriggerwith a pod template exercising a broad set of fields:tolerations,nodeSelector,securityContext(runAsUser/runAsGroup/fsGroup)serviceAccountName,initContainersenv(static + templated),resources.limits/requestsNew test:
"Should apply all pod spec fields to the generated pod"Sends a message with
pod_label,annotation_value, andenv_valuetemplate variables, then asserts each field is present on the resulting pod:Also adds
test-batch-runner-pod-specto the LocalStack queue creation step.